-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - cache poet certifier info #6107
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid querying the same poet /v1/info repeatedly in the 1:N setups.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6107 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 302 302
Lines 32587 32602 +15
=========================================
+ Hits 26605 26608 +3
- Misses 4245 4255 +10
- Partials 1737 1739 +2 ☔ View full report in Codecov by Sentry. |
fasmat
reviewed
Jul 8, 2024
fasmat
approved these changes
Jul 9, 2024
Bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
## Motivation To avoid querying the same poet `/v1/info` endpoint many times in the 1:N setups.
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
cache poet certifier info
[Merged by Bors] - cache poet certifier info
Jul 9, 2024
fasmat
pushed a commit
that referenced
this pull request
Jul 22, 2024
## Motivation To avoid querying the same poet `/v1/info` endpoint many times in the 1:N setups.
4 tasks
fasmat
added a commit
that referenced
this pull request
Jul 22, 2024
* cache poet certifier info (#6107) ## Motivation To avoid querying the same poet `/v1/info` endpoint many times in the 1:N setups. * Update CHANGELOG --------- Co-authored-by: Bartosz Różański <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To avoid querying the same poet
/v1/info
endpoint many times in the 1:N setups.Description
The poet service caches the obtained certifier info for 5 minutes by default (configurable).
Test Plan
added tests
TODO