Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - cache poet certifier info #6107

Closed
wants to merge 5 commits into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Jul 8, 2024

Motivation

To avoid querying the same poet /v1/info endpoint many times in the 1:N setups.

Description

The poet service caches the obtained certifier info for 5 minutes by default (configurable).

Test Plan

added tests

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

To avoid querying the same poet /v1/info repeatedly
in the 1:N setups.
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.6%. Comparing base (0e1bd2c) to head (c10c515).

Files Patch % Lines
activation/poet.go 95.8% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6107     +/-   ##
=========================================
- Coverage     81.6%   81.6%   -0.1%     
=========================================
  Files          302     302             
  Lines        32587   32602     +15     
=========================================
+ Hits         26605   26608      +3     
- Misses        4245    4255     +10     
- Partials      1737    1739      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

activation/poet.go Outdated Show resolved Hide resolved
@poszu
Copy link
Contributor Author

poszu commented Jul 9, 2024

Bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jul 9, 2024
## Motivation

To avoid querying the same poet `/v1/info` endpoint many times in the 1:N setups.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Jul 9, 2024

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title cache poet certifier info [Merged by Bors] - cache poet certifier info Jul 9, 2024
@spacemesh-bors spacemesh-bors bot closed this Jul 9, 2024
@spacemesh-bors spacemesh-bors bot deleted the cache-poet-certifier-info branch July 9, 2024 17:06
fasmat pushed a commit that referenced this pull request Jul 22, 2024
## Motivation

To avoid querying the same poet `/v1/info` endpoint many times in the 1:N setups.
fasmat added a commit that referenced this pull request Jul 22, 2024
* cache poet certifier info (#6107)

## Motivation

To avoid querying the same poet `/v1/info` endpoint many times in the 1:N setups.

* Update CHANGELOG

---------

Co-authored-by: Bartosz Różański <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants