-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - stabilize e2e tests - take 2 #6126
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6126 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 302 302
Lines 32594 32602 +8
=======================================
+ Hits 26652 26665 +13
+ Misses 4200 4197 -3
+ Partials 1742 1740 -2 ☔ View full report in Codecov by Sentry. |
fasmat
reviewed
Jul 11, 2024
poszu
changed the title
query post-service frequently in tests
stabilize e2e tests - take 2
Jul 11, 2024
fasmat
approved these changes
Jul 11, 2024
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
## Motivation Closes #6119
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
stabilize e2e tests - take 2
[Merged by Bors] - stabilize e2e tests - take 2
Jul 11, 2024
spacemesh-bors
bot
deleted the
fix/increase-post-service-query-freq-in-tests
branch
July 11, 2024 10:36
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #6119
Description
There are a few problems with the e2e tests in CI happening on slow runners, visible in selected logs from a failed run:
leading to the failure:
PoST proving time
Despite reducing the difficulty of the PoST proof, it can still take significant time to complete. The most time-consuming part now seems to be RandomX VM initialization. In the logs above it took 7s (from 12:21:02 to 12:21:09), in other runs it took 1s - it's very undeterministic and probably depends on how busy the runner is. Unfortunately, this cannot be speeded up, unless we change the k2pow algorithm to something faster in tests (for example via a CLI flag like
--testing-mode
).Post Service querying interval
The post-service is queried in 2s intervals. That's too long in tests, where the cycle gap is 3.75s. If the proof were unavailable after 2s, the service would be queried again after the CG finished and the builder would be late for the poet round leading to test failure.
Changes
Test Plan
existing tests pass
TODO