Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fallback to PoW if cannot recertify for poet #6197

Closed
wants to merge 2 commits into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Jul 31, 2024

Motivation

Fallback to PoW if cannot recertify after poet registration failed with 401 (unauthorized).

Description

Test Plan

added a test covering this scenario

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.9%. Comparing base (f46277b) to head (c734c48).
Report is 1 commits behind head on develop.

Files Patch % Lines
activation/certifier.go 40.0% 3 Missing and 3 partials ⚠️
activation/poet.go 70.0% 2 Missing and 1 partial ⚠️
sql/localsql/certifier/db.go 77.7% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #6197    +/-   ##
========================================
  Coverage     81.8%   81.9%            
========================================
  Files          302     301     -1     
  Lines        32539   32416   -123     
========================================
- Hits         26631   26554    -77     
+ Misses        4180    4139    -41     
+ Partials      1728    1723     -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

activation/certifier.go Outdated Show resolved Hide resolved
@poszu
Copy link
Contributor Author

poszu commented Aug 1, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 1, 2024
## Motivation

Fallback to PoW if cannot recertify after poet registration failed with 401 (unauthorized).
@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 1, 2024

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title fallback to PoW if cannot recertify for poet [Merged by Bors] - fallback to PoW if cannot recertify for poet Aug 1, 2024
@spacemesh-bors spacemesh-bors bot closed this Aug 1, 2024
@spacemesh-bors spacemesh-bors bot deleted the fix/poet-pow-fallback branch August 1, 2024 12:27
poszu added a commit that referenced this pull request Aug 1, 2024
## Motivation

Fallback to PoW if cannot recertify after poet registration failed with 401 (unauthorized).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants