Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] poet caching opts #6201

Merged
merged 4 commits into from
Aug 1, 2024
Merged

[backport] poet caching opts #6201

merged 4 commits into from
Aug 1, 2024

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Aug 1, 2024

poszu added 2 commits August 1, 2024 15:25
@poszu
configure poet /v1/info cache ttl in presets (#6198)
d2d9e58 
## Motivation

For the cache to work, it needs to have non-zero TTL set
@poszu
cache poet's /v1/pow_params with TTL (#6199)
2820668 
## Motivation

Similarly to /v1/info, we query /v1/pow_params very often (once per submit per node ID). As the contents returned from this endpoint change rarely (once per epoch), it makes sense to cache the result.
@poszu poszu changed the base branch from develop to v1.6 August 1, 2024 13:28
@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.7%. Comparing base (e64a1dc) to head (77b29da).
Report is 8 commits behind head on v1.6.

Additional details and impacted files 
@@           Coverage Diff           @@
##            v1.6   #6201     +/-   ##
=======================================
+ Coverage   81.6%   81.7%   +0.1%     
=======================================
  Files        301     301             
  Lines      32323   32321      -2     
=======================================
+ Hits       26389   26431     +42     
+ Misses      4214    4172     -42     
+ Partials    1720    1718      -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu poszu enabled auto-merge August 1, 2024 14:06
@poszu poszu disabled auto-merge August 1, 2024 14:26
@fasmat fasmat merged commit 334d6cc into v1.6 Aug 1, 2024
23 checks passed
@fasmat fasmat deleted the backport/1.6/poet-opts branch August 1, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasmat fasmat fasmat approved these changes

@ivan4th ivan4th ivan4th approved these changes

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak is a code owner

@acud acud Awaiting requested review from acud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poszu @ivan4th @fasmat