[Merged by Bors] - Update time measurement of metrics for proposal builder in 1:n #6268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
force-pushed
the
miner-metrics-1-n
branch
from
a9226ef to
5816628
Compare
poszu
approved these changes
Aug 19, 2024
|
bors merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6268 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 307 307
Lines 34105 34111 +6
=======================================
+ Hits 27990 27997 +7
+ Misses 4337 4335 -2
- Partials 1778 1779 +1 ☔ View full report in Codecov by Sentry. |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
## Motivation This updates how timing metrics for the proposal builder are calculated.
|
Build failed:
|
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
## Motivation This updates how timing metrics for the proposal builder are calculated.
|
Build failed:
|
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
## Motivation This updates how timing metrics for the proposal builder are calculated.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
## Motivation This updates how timing metrics for the proposal builder are calculated.
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
fasmat
added a commit
that referenced
this pull request
Aug 22, 2024
## Motivation This updates how timing metrics for the proposal builder are calculated.
4 tasks
fasmat
added a commit
that referenced
this pull request
Aug 22, 2024
## Motivation This updates how timing metrics for the proposal builder are calculated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This updates how timing metrics for the proposal builder are calculated.
Description
At the moment the measured timestamps include waiting times for other identities that might be managed by the node. I updated the
latencystruct to still calculate the total time as before, since for the decision if a proposal is late or not the absolute time betweenstartand the publication are relevant, but I changed the in between steps to only measure the time the identity of interest was busy with the step.Test Plan
n/a, just updated how metrics are collected
TODO