Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Cache the full response of the v1/info #6274

Closed
wants to merge 5 commits into from

Conversation

ConvallariaMaj
Copy link
Contributor

Motivation

Cache full response of the v1/info to decrease amount of requests to poet server

Description

Closes #6226

  • cache full full response of the v1/info
  • remove requesting certifier info separately

Test Plan

Unit tests implemented

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

# Conflicts:
#	activation/poet_client_test.go
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.8%. Comparing base (fd3833a) to head (e7a2606).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
activation/poet.go 93.3% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #6274   +/-   ##
=======================================
  Coverage     81.7%   81.8%           
=======================================
  Files          312     312           
  Lines        34625   34613   -12     
=======================================
+ Hits         28303   28315   +12     
+ Misses        4483    4459   -24     
  Partials      1839    1839           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

activation/e2e/poet_test.go Show resolved Hide resolved
@pigmej
Copy link
Member

pigmej commented Aug 29, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 29, 2024
## Motivation
Cache full response of the v1/info to decrease amount of requests to poet server
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Cache the full response of the v1/info [Merged by Bors] - Cache the full response of the v1/info Aug 29, 2024
@spacemesh-bors spacemesh-bors bot closed this Aug 29, 2024
@spacemesh-bors spacemesh-bors bot deleted the issue-6226 branch August 29, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change poet client to cache the full response of the v1/info
4 participants