[Merged by Bors] - Prevent connection pool from emptying upon panics #6408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ensure an active statement is reset even if
decoder
indb.Exec
panicsDescription
Crawshaw panics internally when putting a connection back into the pool that was not reset.
SetInterupt
does this explicitly which is why #6407 also fixes this issue. This change has a smaller footprint and adds a test.Test Plan
New test for panics in decoder
TODO