[Merged by Bors] - Improve performance of proposal builder by not DB inserting active set if not necessary #6422
+101
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t an immediate transaction
… put back into the pool
fasmat
requested review from
dshulyak,
poszu,
ivan4th,
acud and
jellonek
as code owners
|
bors try |
|
bors try |
tryAlready running a review |
ivan4th
approved these changes
Oct 29, 2024
tryBuild failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
…t if not necessary (#6422) ## Motivation Closes #6418 The first proposal created by a node for any identity triggers persisting the activeset that is used by all identities of the node. This can be a slow process (especially when many ATXs are received by the node) and is usually not necessary, because the activeset is most likely already in the DB. This PR moves persisting the active set to the beginning of an epoch and avoids a DB write if not necessary (which will usually be the case).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6422 +/- ##
=======================================
Coverage 79.7% 79.7%
=======================================
Files 328 328
Lines 42977 42984 +7
=======================================
+ Hits 34256 34292 +36
+ Misses 6782 6753 -29
Partials 1939 1939 ☔ View full report in Codecov by Sentry. |
jellonek
approved these changes
Oct 29, 2024
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
4 tasks
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
## Motivation Follow up to #6422: Update changlog and remove unused metric.
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
## Motivation Follow up to #6422: Update changlog and remove unused metric.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #6418
The first proposal created by a node for any identity triggers persisting the activeset that is used by all identities of the node. This can be a slow process (especially when many ATXs are received by the node) and is usually not necessary, because the activeset is most likely already in the DB.
This PR moves persisting the active set to the beginning of an epoch and avoids a DB write if not necessary (which will usually be the case).
Description
All uses of
WithTxhave been renamed toWithTxImmediate(because they are). A newWithTxwas added that starts a normal instead of an immediate transaction.This transaction is used to first do a select on the available active sets in the DB and only write the used active set if it doesn't exist yet. Since most nodes use the same active set that is pre-shared this will almost never trigger an actual insert preventing the requirement to acquire a DB write lock and speed up the process.
Additionally I fixed an issue where if beginning a transaction failed (because for instance the TX was canceled already via context), the connection used was not returned to the DB pool. This fixes the flaky
TestSyncertest in themalsyncpackage and ensures this doesn't happen during normal node operation.Test Plan
existing tests pass
TODO