[Merged by Bors] - Fix db-allow-schema-drift handling #6431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan4th
requested review from
dshulyak,
fasmat,
poszu,
acud and
jellonek
as code owners
ivan4th
changed the title
jellonek
approved these changes
Nov 4, 2024
|
tbh. few lines above db was already checked for schema difference, so maybe we should there even use |
|
@jellonek makes sense, it's actually enough to just ignore schema drift for the api conn pool |
jellonek
approved these changes
Nov 4, 2024
|
bors merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6431 +/- ##
=======================================
Coverage 79.8% 79.8%
=======================================
Files 341 341
Lines 44204 44205 +1
=======================================
+ Hits 35282 35294 +12
+ Misses 6926 6918 -8
+ Partials 1996 1993 -3 ☔ View full report in Codecov by Sentry. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
------- ## Motivation `db-allow-schema-drift` stopped working after adding separate conn pool for the API
fasmat
approved these changes
Nov 4, 2024
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
db-allow-schema-driftstopped working after adding separate conn pool for the APIDescription
Fix schema drift handling for the API db connection pool
Test Plan
Verify on a mainnet node