[Merged by Bors] - Remove deprecated config option for PoET servers #6498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
requested review from
dshulyak,
poszu,
ivan4th,
acud and
jellonek
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #6498 +/- ##
=========================================
Coverage ? 79.9%
=========================================
Files ? 352
Lines ? 46437
Branches ? 0
=========================================
Hits ? 37119
Misses ? 7210
Partials ? 2108 ☔ View full report in Codecov by Sentry. |
fasmat
force-pushed
the
remove-deprecated-poet-server-cfg
branch
from
af2a90d to
3f08cf5
Compare
poszu
approved these changes
Nov 27, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
## Motivation The setting has been marked as deprecated in `v1.4.0` released 2024-03-14. It should be safe to remove this config setting now.
|
Build failed:
|
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
## Motivation The setting has been marked as deprecated in `v1.4.0` released 2024-03-14. It should be safe to remove this config setting now.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The setting has been marked as deprecated in
v1.4.0released 2024-03-14. It should be safe to remove this config setting now.Description
Removal of deprecated
poet-serverconfig option.Test Plan
TODO