[Merged by Bors] - sync2: fptree: don't get next in FingerprintInterval if not needed #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan4th
requested review from
dshulyak,
fasmat,
poszu,
acud and
jellonek
as code owners
ivan4th
force-pushed
the
sync2/no-next
branch
from
ff8684a to
a0aea57
Compare
Retrieving the next item when fingerprinting an interval is only useful during slow splitting, when we need to split a range but "easy split" (involving only in-memory FPTree) fails. In other cases, the next item is not really needed and getting it may incur an unwanted database access. This also fixes intermittent failures of TestFPTreeManyItems test.
ivan4th
force-pushed
the
sync2/no-next
branch
from
a0aea57 to
fca7843
Compare
fasmat
approved these changes
Dec 19, 2024
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #6558 +/- ##
=======================================
Coverage 79.8% 79.8%
=======================================
Files 354 354
Lines 47015 47023 +8
=======================================
+ Hits 37534 37556 +22
+ Misses 7351 7343 -8
+ Partials 2130 2124 -6 ☔ View full report in Codecov by Sentry. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
…6558) ## Motivation Retrieving the next item (one immediately following the fingerprinted interval) when fingerprinting an interval is only useful during slow splitting, when we need to split a range but "easy split" (involving only in-memory FPTree) fails. In other cases, the next item is not really needed and getting it may incur an unwanted database access. `TestFPTreeManyItems` fails intermittently when it happens to fingerprint an empty range during random testing due to a problem with handling next items.
|
Build failed: |
|
Unrelated |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
…6558) ## Motivation Retrieving the next item (one immediately following the fingerprinted interval) when fingerprinting an interval is only useful during slow splitting, when we need to split a range but "easy split" (involving only in-memory FPTree) fails. In other cases, the next item is not really needed and getting it may incur an unwanted database access. `TestFPTreeManyItems` fails intermittently when it happens to fingerprint an empty range during random testing due to a problem with handling next items.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Retrieving the next item (one immediately following the fingerprinted interval) when fingerprinting an interval is only useful during slow splitting, when we need to split a range but "easy split" (involving only in-memory FPTree) fails. In other cases, the next item is not really needed and getting it may incur an unwanted database access.
TestFPTreeManyItemsfails intermittently when it happens to fingerprint an empty range during random testing due to a problem with handling next items.Description
This removes unneeded retrieval of the next item and fixes
TestFPTreeManyItems.