[Merged by Bors] - sync2: fix Advance race #6588
Closed
+51
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrderedSet.Advance is not threadsafe. SetSyncBase already has a mutex which it's using for advancing so let's use it when advancing the OrderedSet on timer, too.
ivan4th
requested review from
dshulyak,
fasmat,
poszu,
acud,
jellonek and
kacpersaw
as code owners
fasmat
approved these changes
Jan 3, 2025
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
## Motivation OrderedSet.Advance is not threadsafe, but it's invoked on timer w/o any locking.
poszu
approved these changes
Jan 3, 2025
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #6588 +/- ##
=======================================
Coverage 79.8% 79.9%
=======================================
Files 356 356
Lines 47316 47321 +5
=======================================
+ Hits 37775 37820 +45
+ Misses 7394 7357 -37
+ Partials 2147 2144 -3 ☔ View full report in Codecov by Sentry. |
|
Build failed (retrying...): |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
## Motivation OrderedSet.Advance is not threadsafe, but it's invoked on timer w/o any locking.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
OrderedSet.Advance is not threadsafe, but it's invoked on timer w/o any locking.
Description
SetSyncBase already has a mutex which it's using for advancing so let's use it when advancing the OrderedSet on timer, too.
Test Plan
Existing tests must pass.