-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only init OpenCL once per Initialization #139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87cca30
to
4f1d8c3
Compare
Now the speed is as expected but it still crashed with
|
That's probably caused by RUST side though. |
9af84de
to
f75bc4c
Compare
f75bc4c
to
3a247c9
Compare
88a6395
to
bfc87c9
Compare
poszu
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the API of
internal/postrs
to preserve an instance ofpost-rs
'sInitializer
until explicitly freed.ScryPositions
has been removed and replaced by a new structScrypt
that has to be Instantiated withNewScrypt
. This instance holds a reference to the rust exposed initializer that has to be explicitly freed by callingScrypt::Close
. The change has been propagated up different layers of abstructions into theinitialization.Initializer
.gpu-post
has been removed due to becoming incompatible with the recent changes.Do not merge before spacemeshos/post-rs#59
Closes #138