-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add second required argument to jwst get_default_context curl command #1086
Conversation
The workflow is now working again as seen by a context being found: |
I can't request reviewers or add labels. I'd say this is a "no changelog" change and perhaps @alphasentaurii would give this a review. One open question is if similar server-side API changes are planned for hst and roman. If so, the workflow will need to be updated for those calls (when the servers are updated). |
The download and cache workflow is failing: |
Sorry just seeing this now - I implemented this exact change for JWST in another PR (after looking at your suggestion on Slack re: stdatamodels) that was merged last night to resolve related sync errors (see release 12.0.3). Rather than close this PR, if you want you can rebase from master and add the |
When I made this change as part of #1088 the CI didn't succeed until after I merged |
should we add |
Thanks for taking a look. I'm going to close this PR. jwst and soon romancal and gwcs have modified versions of this workflow. jwst main is currently using |
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)news fragment change types...
changes/<PR#>.hst.rst
: HST reference fileschanges/<PR#>.jwst.rst
: JWST reference fileschanges/<PR#>.roman.rst
: Roman reference fileschanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.testing.rst
: change to tests or test automationchanges/<PR#>.general.rst
: infrastructure or miscellaneous change