Use oldest-supported-numpy in pyproject.toml #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 79.75% 79.75%
=======================================
Files 5 5
Lines 326 326
=======================================
Hits 260 260
Misses 66 66 Continue to review full report at Codecov.
|
eslavich
approved these changes
Feb 23, 2021
| "setuptools>=42", | ||
| "setuptools_scm[toml]>=3.4", | ||
| "wheel", | ||
| "oldest-supported-numpy", |
There was a problem hiding this comment.
Well that is a handy dandy feature isn't it
There was a problem hiding this comment.
We may want to do this for other spacetelescope projects that have C code that need numpy installed to build/compile. Maybe we should file issues for the others as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the latest version of
numpyas the build dependency, use the oldest compatible one via the meta packagehttps://github.com/scipy/oldest-supported-numpy
so that the compiled code can be used with any new version of
numpyin the runtime environment.This should resolve the issue discussed in spacetelescope/jwst#5744
For more detail, see pypa/pip#9542