HLA-1407: Implemented fixes to address uneven detection thresholds in HAP catalogs #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlwastro
approved these changes
Jan 27, 2025
…thresholds in the HAP catalogs due to bugs in the function, make_wht_masks, which intends to create weight masks covering the full drizzled output footprint. A somewhat related bug in the compute_threshold method associated with only the Segment catalog was also addressed. The "scale factor" which causes the RMS computation to be too small was deleted. The RMS computation for the Point and Segment catalogs is now the same.
mdlpstsci
force-pushed
the
detectionThreshold
branch
from
effe005 to
4f6d6f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves HLA-407
Closes #
Implemented fixes recommended by R.White to address uneven detection thresholds in the HAP catalogs due to bugs in the function, make_wht_masks, which intends to create weight masks covering the full drizzled output footprint. A somewhat related bug in the compute_threshold method associated with only the Segment catalog was also addressed. The "scale factor" which causes the RMS computation to be too small was deleted. The RMS computation for the Point and Segment catalogs is now the same.
Checklist for maintainers
CHANGELOG.rstwithin the relevant release section