Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-1413: Replaced deprecated class #1950

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

mdlpstsci
Copy link
Collaborator

@mdlpstsci mdlpstsci commented Feb 14, 2025

Resolves HLA-1413

Closes #

The PR replaces the deprected class IntegratedGaussianPRF with CircularGaussianSigmaPRF.

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant label(s)

@mdlpstsci mdlpstsci added enhancement jirahub-ignore Avoid linking to Jira labels Feb 14, 2025
@mdlpstsci mdlpstsci requested a review from s-goldman February 14, 2025 20:31
@mdlpstsci mdlpstsci self-assigned this Feb 14, 2025
@mdlpstsci mdlpstsci requested a review from a team as a code owner February 14, 2025 20:31
@s-goldman
Copy link
Collaborator

s-goldman commented Feb 18, 2025

I ran a test run with the full spacetelescope/RegressionTests suite. That should include --bigdata and --slow tests. Once that passes feel free to merge this.

Copy link
Collaborator

@s-goldman s-goldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@mdlpstsci mdlpstsci merged commit dcdca26 into spacetelescope:main Feb 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement jirahub-ignore Avoid linking to Jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants