HLA-1417: Validation check for WCS solutions from astrometry database #1958
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-goldman
added
in progress
Do Not Merge
|
Code behavior verified using "fresh" datasets (jb2o04), altering the header target position (RA_TARG), and seeing the warning only for the altered dataset. |
s-goldman
added
ready-for-final-review
and removed
Do Not Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves HLA-1417
This PR adds a validation check to adopted WCS solution taken from the astrometry database. The check makes sure that the CRVAL1 and CRVAL2 values (reference pixel coordinates in degrees) have a separation less than a certain threshold; otherwise a warning is issued.
Our current working warning separation threshold is 1 degrees, but this should be refined.
Checklist for maintainers
CHANGELOG.rstwithin the relevant release section