-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin ipywidgets to avoid breaking standalone app #1611
Conversation
Codecov ReportBase: 86.28% // Head: 86.28% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
=======================================
Coverage 86.28% 86.28%
=======================================
Files 94 94
Lines 9366 9366
=======================================
Hits 8081 8081
Misses 1285 1285 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jinja2 error on install or when you run it? |
When running, it's complaining about missing some file: |
I don't see any jinja2 error (not a clean install, just downgrading) but I also don't know where to look or what you did to trigger it. I ran Imviz on notebook and didn't see it in terminal or in the notebook. |
I didn't see it either when I just downgraded |
I just created a fresh Python 3.10 conda env and installed this branch (editable). Still no jinja2 error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, downgrading ipywidgets also fixed the spinner mystery at #1598 (comment)
One approval is probably enough for this, eh? |
As long as you resolved your jinja2 problem... |
ipywidgets
8.0 broke compatibility withvoila
, so we'll have to pin it at least for now. I got a jinja2 error after a fresh install with this pin though, could someone else test and see if that's just something messed up in my local env?ipywidgets
8 voila-dashboards/voila#1188