Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ipywidgets to avoid breaking standalone app #1611

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Aug 30, 2022

ipywidgets 8.0 broke compatibility with voila, so we'll have to pin it at least for now. I got a jinja2 error after a fresh install with this pin though, could someone else test and see if that's just something messed up in my local env?

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 86.28% // Head: 86.28% // No change to project coverage 👍

Coverage data is based on head (d294dfb) compared to base (6e6626c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1611   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files          94       94           
  Lines        9366     9366           
=======================================
  Hits         8081     8081           
  Misses       1285     1285           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim
Copy link
Contributor

pllim commented Aug 30, 2022

jinja2 error on install or when you run it?

@rosteen
Copy link
Collaborator Author

rosteen commented Aug 30, 2022

When running, it's complaining about missing some file: jinja2.exceptions.TemplateNotFound: index.html.j2

@rosteen rosteen added the no-changelog-entry-needed changelog bot directive label Aug 30, 2022
@pllim
Copy link
Contributor

pllim commented Aug 30, 2022

I don't see any jinja2 error (not a clean install, just downgrading) but I also don't know where to look or what you did to trigger it. I ran Imviz on notebook and didn't see it in terminal or in the notebook.

@rosteen
Copy link
Collaborator Author

rosteen commented Aug 30, 2022

I didn't see it either when I just downgraded ipywidgets, only when I did a full clean install with the new pin.

@pllim
Copy link
Contributor

pllim commented Aug 30, 2022

I just created a fresh Python 3.10 conda env and installed this branch (editable). Still no jinja2 error.

@pllim pllim requested a review from camipacifici August 30, 2022 17:29
@pllim pllim added this to the 2.11 milestone Aug 30, 2022
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, downgrading ipywidgets also fixed the spinner mystery at #1598 (comment)

@rosteen rosteen added the trivial Only needs one approval instead of two label Aug 30, 2022
@rosteen
Copy link
Collaborator Author

rosteen commented Aug 30, 2022

One approval is probably enough for this, eh?

@rosteen rosteen merged commit 853c045 into spacetelescope:main Aug 30, 2022
@pllim
Copy link
Contributor

pllim commented Aug 30, 2022

As long as you resolved your jinja2 problem...

@pllim pllim changed the title Pin ipwidgets to avoid breaking standalone app Pin ipywidgets to avoid breaking standalone app Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two Upstream fix required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants