Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plots in popout window not scaled properly (by pinning voila<0.4) #1791

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

mariobuikhuizen
Copy link
Collaborator

@mariobuikhuizen mariobuikhuizen commented Oct 28, 2022

This is caused by Voila 0.4.0 which is now based on ipywidgets 8. The Layout widget of v7 could not be created, resulting in the height of the plots not being set.

Fixes: #1787

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added this to the 3.1.1 milestone Oct 28, 2022
@pllim pllim added bug Something isn't working 💤backport-v3.1.x on-merge: backport to v3.1.x embed Regarding issues with front-end embedding labels Oct 28, 2022
@pllim
Copy link
Contributor

pllim commented Oct 28, 2022

But this isn't a permanent fix, is it? I was just hoping we could get rid of maxversion pin of ipywidgets at #1788

@mariobuikhuizen
Copy link
Collaborator Author

mariobuikhuizen commented Oct 28, 2022

Ah, yes, using ipywidgets 8 instead would also work. Although it would require ipywidgets>=8 in addition to voila>=0.4

@mariobuikhuizen mariobuikhuizen changed the title fix: plots in popout window not scaled propertly fix: plots in popout window not scaled properly Oct 28, 2022
@pllim
Copy link
Contributor

pllim commented Oct 28, 2022

Is it fair to say that #1788 would supersede this?

@pllim pllim reopened this Nov 2, 2022
@pllim
Copy link
Contributor

pllim commented Nov 2, 2022

#1613 does not fix all the bugs, so I think we need this after all in the meantime.

This is caused by Voila 0.4.0 which is now based on ipywidgets 8.
The Layout widget of v7 could not be created, resulting in the
height of the plots not being set.

See: spacetelescope#1787
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 88.11% // Head: 88.11% // No change to project coverage 👍

Coverage data is based on head (51be9a8) compared to base (d16cb27).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1791   +/-   ##
=======================================
  Coverage   88.11%   88.11%           
=======================================
  Files          95       95           
  Lines       10247    10247           
=======================================
  Hits         9029     9029           
  Misses       1218     1218           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Spinner shows in Link Control when click on WCS.
✔️ Standalone app still works.
✔️ Viewer resizes display when popped out.

@pllim pllim changed the title fix: plots in popout window not scaled properly fix: plots in popout window not scaled properly (by pinning voila<0.4) Nov 2, 2022
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make a ticket to remove the maxversion pin when it is no longer necessary?

@pllim
Copy link
Contributor

pllim commented Nov 2, 2022

Re: ticket -- I have updated #1613 to capture that as well, so no need for new ticket.

@pllim pllim merged commit 1a0c846 into spacetelescope:main Nov 2, 2022
@pllim
Copy link
Contributor

pllim commented Nov 2, 2022

Let's get this in. Thanks, all!

pllim added a commit that referenced this pull request Nov 2, 2022
…1-on-v3.1.x

Backport PR #1791 on branch v3.1.x (fix: plots in popout window not scaled properly (by pinning voila<0.4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working embed Regarding issues with front-end embedding no-changelog-entry-needed changelog bot directive Ready for final review 💤backport-v3.1.x on-merge: backport to v3.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Viewers not properly sized when popped out
3 participants