-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: plots in popout window not scaled properly (by pinning voila<0.4) #1791
Conversation
But this isn't a permanent fix, is it? I was just hoping we could get rid of maxversion pin of ipywidgets at #1788 |
Ah, yes, using ipywidgets 8 instead would also work. Although it would require |
Is it fair to say that #1788 would supersede this? |
#1613 does not fix all the bugs, so I think we need this after all in the meantime. |
This is caused by Voila 0.4.0 which is now based on ipywidgets 8. The Layout widget of v7 could not be created, resulting in the height of the plots not being set. See: spacetelescope#1787
938e521
to
51be9a8
Compare
Codecov ReportBase: 88.11% // Head: 88.11% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
=======================================
Coverage 88.11% 88.11%
=======================================
Files 95 95
Lines 10247 10247
=======================================
Hits 9029 9029
Misses 1218 1218 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ Spinner shows in Link Control when click on WCS.
✔️ Standalone app still works.
✔️ Viewer resizes display when popped out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make a ticket to remove the maxversion pin when it is no longer necessary?
Re: ticket -- I have updated #1613 to capture that as well, so no need for new ticket. |
…ed properly (by pinning voila<0.4)
Let's get this in. Thanks, all! |
…1-on-v3.1.x Backport PR #1791 on branch v3.1.x (fix: plots in popout window not scaled properly (by pinning voila<0.4))
This is caused by Voila 0.4.0 which is now based on ipywidgets 8. The Layout widget of v7 could not be created, resulting in the height of the plots not being set.
Fixes: #1787
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.