-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: lcviz TPFs are sliced by cube index rather than time slice #3235
Conversation
8a17fa6
to
b00ae03
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3235 +/- ##
==========================================
- Coverage 88.62% 88.61% -0.01%
==========================================
Files 125 125
Lines 18775 18779 +4
==========================================
+ Hits 16639 16641 +2
- Misses 2136 2138 +2 ☔ View full report in Codecov by Sentry. |
@bmorris3 - is there a reason this was never out of draft/merged? If not, can you please rebase and remilestone to 4.1.1? |
b00ae03
to
4c71275
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked when I tested it, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…e index rather than time slice
… than time slice (#3405) Co-authored-by: Brett M. Morris <[email protected]>
Description
TPFs in lcviz should be sliceable by their time axes. Somewhere since jdaviz v3.9, a bug was introduced that causes the step size in the lcviz Time Selector plugin to be fixed to integer values.
lcviz-slice.mov
This PR corrects the slice values for cube axes defined by temporal WCS. Here's a demo after this PR:
lcviz-slice-fix.mov
The failing devdeps tests in this PR should be fixed by #3232.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.