Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for dataset-selection in cubeviz spectral extraction #3411

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jan 28, 2025

Description

This pull request adds the missing UI dropdown for input cube selection in cubeviz's spectral extraction.

Currently milestoning as a bug since the API existed, but we should test to make sure that there aren't unintended consequences since elsewhere we do assume only a single INPUT flux cube (but maybe this is safe because it is guaranteed to be the shape).

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 backport-v4.1.x on-merge: backport to v4.1.x labels Jan 28, 2025
@kecnry kecnry added this to the 4.1.1 milestone Jan 28, 2025
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Jan 28, 2025
@camipacifici
Copy link
Contributor

Tested a few things and could not break it. Works for me, thanks!

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.51%. Comparing base (329c969) to head (f13fe0b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3411   +/-   ##
=======================================
  Coverage   87.51%   87.51%           
=======================================
  Files         128      128           
  Lines       19901    19901           
=======================================
  Hits        17417    17417           
  Misses       2484     2484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review January 28, 2025 16:43
@kecnry kecnry added the trivial Only needs one approval instead of two label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1.x on-merge: backport to v4.1.x cubeviz plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants