Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Codecov carryforward flags #5406

Merged

Conversation

jdavies-st
Copy link
Collaborator

@jdavies-st jdavies-st commented Oct 14, 2020

Make the nightly tests flag carryforward so that we can see the coverage of the repo from both unit and nightly tests combined. This should also only compare CI unit tests to previous coverage of CI unit tests, not to coverage of the nightly tests. 🤞

Also, make threshold be 0.1% so that when a few lines of code are deleted, the codecov/project check doesn't fail because the denominator has gotten smaller.

Resolves #4920

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #5406 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5406      +/-   ##
==========================================
+ Coverage   52.39%   52.46%   +0.07%     
==========================================
  Files         414      414              
  Lines       37681    37744      +63     
  Branches     5828     5842      +14     
==========================================
+ Hits        19744    19804      +60     
- Misses      16676    16680       +4     
+ Partials     1261     1260       -1     
Flag Coverage Δ
#unit 52.46% <ø> (+0.07%) ⬆️
Impacted Files Coverage Δ
jwst/pipeline/calwebb_image3.py 32.55% <0.00%> (-2.45%) ⬇️
jwst/datamodels/model_base.py 84.56% <0.00%> (-0.89%) ⬇️
jwst/transforms/models.py 86.91% <0.00%> (-0.30%) ⬇️
jwst/extract_1d/extract.py 9.05% <0.00%> (-0.13%) ⬇️
jwst/jump/jump.py 100.00% <0.00%> (ø)
jwst/resample/gwcs_drizzle.py 57.00% <0.00%> (ø)
jwst/extract_1d/extract_1d_step.py 9.09% <0.00%> (ø)
jwst/outlier_detection/outlier_detection_scaled.py 20.51% <0.00%> (ø)
jwst/assign_wcs/util.py 63.17% <0.00%> (+0.31%) ⬆️
jwst/resample/resample_spec_step.py 75.60% <0.00%> (+0.60%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bfb8b1...86b62a7. Read the comment docs.

@jdavies-st jdavies-st requested review from nden and hbushouse October 26, 2020 16:15
@jdavies-st
Copy link
Collaborator Author

jdavies-st commented Oct 26, 2020

Oops, forgot turn turn on coverage reporting for the nightly tests. Done now.

@jdavies-st jdavies-st merged commit 850b2bb into spacetelescope:master Oct 26, 2020
@jdavies-st jdavies-st deleted the codecov-carryforward-flags branch October 26, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Carryforward Codecov flags to repo
2 participants