You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A suppress_one_group boolean variable has been added as a parameter to the ramp fitting step class.
When true (the default) saturated ramps with only the 0th group being good will be treated as completely saturated ramps. The calculations will be done as if all calculations are saturated, but the DQ flags will be set as if the first group is good, i.e., the pixel DQ will not have DO_NOT_USE set.
When false saturated ramps with only the 0th group being good will be treated as the normal special case of having only one good group.
Many unit tests are expected to fail until the corresponding PR in STCAL has been merged.
Failure in CI for oldest dependencies is due to the use of stcal 0.6.0, which does not support the new "suppress_one_group" step param. It is supported in stcal 0.6.1, which is used in the other passing CI tests.
…etelescope#6737)
* Modify step code to add switch for one group suppression and unit tests for the switch
.
* Adding changes to the change log.
* Making changes due to code review.
* Making changes due to code review.
* Making changes due to code review.
* Changing tests for DQ flag computation changes.
* Updating the arguments to the ramp fit step to acount for the new argument for the new feature.
Co-authored-by: Howard Bushouse <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hbushouse
changed the title
Closes #6013
Resolves JP-2071
Description
A
suppress_one_groupboolean variable has been added as a parameter to the ramp fitting step class.When true (the default) saturated ramps with only the 0th group being good will be treated as completely saturated ramps. The calculations will be done as if all calculations are saturated, but the DQ flags will be set as if the first group is good, i.e., the pixel DQ will not have DO_NOT_USE set.
When false saturated ramps with only the 0th group being good will be treated as the normal special case of having only one good group.
Many unit tests are expected to fail until the corresponding PR in STCAL has been merged.
Checklist