Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile under windows #6905

Closed
wants to merge 3 commits into from
Closed

Compile under windows #6905

wants to merge 3 commits into from

Conversation

stsci-hack
Copy link
Contributor

@stsci-hack stsci-hack commented Jun 29, 2022

Closes #
Resolves JP-nnnn

Description

This PR contains the simple changes to the C code necessary to allow the C extensions to compile under Windows. These changes swap out an indeterminate array definition with a redefinition using malloc to account for the varying size of the array for each dataset.

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #6905 (7281c72) into master (64afee0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6905   +/-   ##
=======================================
  Coverage   79.36%   79.36%           
=======================================
  Files         418      418           
  Lines       37343    37343           
=======================================
  Hits        29636    29636           
  Misses       7707     7707           
Flag Coverage Δ *Carryforward flag
nightly 79.34% <ø> (ø) Carriedforward from 64afee0
unit 53.28% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64afee0...7281c72. Read the comment docs.

@pllim
Copy link
Contributor

pllim commented Sep 29, 2022

Is this all it takes for this package to run on Windows? Yes, please!

Would be nice to also add the Windows CI here, to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants