-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes for tox>=4.0
release
#7384
changes for tox>=4.0
release
#7384
Conversation
70b443b
to
760310d
Compare
b8d9795
to
b279802
Compare
since Tox 4.0 is using PEP517, we run into the C extension issue noted in #7386 |
6aa99a4
to
dac2425
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can unpin tox everywhere and just do
[testenv:check-dependencies]
description = verify that install_requires in setup.cfg has correct dependencies
usedevelop = false
extras =
commands =
verify_install_requires
For some reason the new version of tox doesn't install the jwst
wheel when usedevelop=true. Also, we had (by mistake) been using test dependencies in this job, which was a mistake, so the test extras needs to be turned off. The whole point of the job is to make sure the dependencies are accounted for without the test extras installed.
It's important that the pyargs job has usedevelop=false. The others need usedevelop=true, as that's where they are picking up installed code (built C binaries) when we run pytest.
cf03b68
to
4e34084
Compare
using |
3e865e3
to
76ccdd1
Compare
da91d93
to
c900411
Compare
blocked by #7406 |
c900411
to
d317b21
Compare
48eb98a
to
45560ff
Compare
45560ff
to
8304a5d
Compare
rebased and formatting changes, plus added an intermediate step to cache CRDS before testing |
e77de60
to
90aa708
Compare
Codecov ReportBase: 78.65% // Head: 78.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #7384 +/- ##
=======================================
Coverage 78.65% 78.65%
=======================================
Files 455 455
Lines 39168 39168
=======================================
Hits 30806 30806
Misses 8362 8362
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closes #7383
This PR addresses the issue raised in #7383
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR