-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-2013 NIRSpec leakcal and nodded exposures #7426
Conversation
Running regressions tests now |
dab75c3
to
dda92d2
Compare
Codecov ReportBase: 78.61% // Head: 78.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #7426 +/- ##
==========================================
- Coverage 78.61% 78.51% -0.11%
==========================================
Files 455 455
Lines 39143 39211 +68
==========================================
+ Hits 30773 30787 +14
- Misses 8370 8424 +54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The regression test show 8 failures. 4 failures are from tests that has an extra keyword S_IMPRINT SKIPPED. |
I re-ran the regression tests and now there are only 4 "failures" - these are just 1 difference in header that now has the IMPRINT step set to skipped. In these cases it should be set to skipped because the data is not NIRSpec IFU data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Resolves JP-2013
Closes #5911
This PR follows changes made in how level-2b associations are created for NIRSpec exposures with both leakcal and nodded exposures (#7405). The calspec2 pipeline has been changed to subtract leakcal images from science and background data before the background step is run on the science data.
Checklist for maintainers
CHANGES.rst
within the relevant release section[How to run regression tests on a PR]: results
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/534/