Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2928: Update NIRISS AMI3 regtest with flight data #7434

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented Jan 14, 2023

Partially resolves JP-2928

This PR updates the test_niriss_ami3 regtest module to use recent in-flight data as input. Note that the test_ami_average_with_sizes test is no longer needed, because the one main test now also covers the case where dithering of the target and/or psf source(s) leads to outputs of different sizes that need to be averaged. All new input and truth files have been uploaded to artifactory and the new tests pass when run locally.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Base: 78.60% // Head: 78.60% // No change to project coverage 👍

Coverage data is based on head (6760b8b) compared to base (e2284d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7434   +/-   ##
=======================================
  Coverage   78.60%   78.60%           
=======================================
  Files         455      455           
  Lines       39148    39148           
=======================================
  Hits        30771    30771           
  Misses       8377     8377           
Flag Coverage Δ *Carryforward flag
nightly 78.59% <ø> (ø) Carriedforward from e2284d1
unit 51.41% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@dmggh dmggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hbushouse hbushouse merged commit f25d3ee into spacetelescope:master Jan 17, 2023
@hbushouse hbushouse deleted the nis_ami_regtest branch January 17, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants