Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3078: Add support custom reference WCS for the resample step #7442

Merged

Conversation

mcara
Copy link
Member

@mcara mcara commented Jan 29, 2023

Resolves JP-3078

This PR addsoutput_wcs argument to the resample_step and resample_spec_step that allows users to provide their own reference GWCS to the resample step.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Regression test(s):

https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/554/

@mcara mcara added this to the Build 9.2 milestone Jan 29, 2023
@mcara mcara requested review from nden and hbushouse January 29, 2023 02:48
@mcara mcara self-assigned this Jan 29, 2023
@mcara mcara force-pushed the support-custom-resample-step-output-wcs branch 3 times, most recently from 76eea0b to b757e77 Compare January 29, 2023 04:00
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 78.01% // Head: 78.58% // Increases project coverage by +0.56% 🎉

Coverage data is based on head (c989a20) compared to base (04688a7).
Patch has no changes to coverable lines.

❗ Current head c989a20 differs from pull request most recent head 04ef8dc. Consider uploading reports for the commit 04ef8dc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7442      +/-   ##
==========================================
+ Coverage   78.01%   78.58%   +0.56%     
==========================================
  Files         453      455       +2     
  Lines       36830    39200    +2370     
==========================================
+ Hits        28732    30804    +2072     
- Misses       8098     8396     +298     
Flag Coverage Δ
nightly 78.57% <0.00%> (+0.56%) ⬆️
unit 51.35% <0.00%> (+0.90%) ⬆️
Impacted Files Coverage Δ
jwst/datamodels/schema.py 6.16% <0.00%> (-93.84%) ⬇️
jwst/datamodels/asn.py 51.51% <0.00%> (-48.49%) ⬇️
jwst/datamodels/tsophot.py 51.72% <0.00%> (-48.28%) ⬇️
jwst/datamodels/multiexposure.py 57.89% <0.00%> (-42.11%) ⬇️
jwst/datamodels/nirspec_flat.py 60.71% <0.00%> (-39.29%) ⬇️
jwst/datamodels/multiextract1d.py 61.53% <0.00%> (-38.47%) ⬇️
jwst/datamodels/multispec.py 66.66% <0.00%> (-33.34%) ⬇️
jwst/datamodels/multicombinedspec.py 66.66% <0.00%> (-33.34%) ⬇️
jwst/datamodels/wavemap.py 69.23% <0.00%> (-30.77%) ⬇️
jwst/datamodels/spectrace.py 69.23% <0.00%> (-30.77%) ⬇️
... and 210 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcara mcara force-pushed the support-custom-resample-step-output-wcs branch 3 times, most recently from 52ab3b2 to 404c589 Compare February 2, 2023 20:14
@mcara mcara force-pushed the support-custom-resample-step-output-wcs branch 3 times, most recently from 0874116 to 24a8ce0 Compare February 8, 2023 17:05
@mcara mcara force-pushed the support-custom-resample-step-output-wcs branch from 24a8ce0 to 5809b04 Compare February 9, 2023 15:19
@hbushouse hbushouse removed the MIRI label Feb 10, 2023
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Updated docs seem to build correctly.

@mcara mcara merged commit fbe36f0 into spacetelescope:master Feb 11, 2023
@mcara mcara deleted the support-custom-resample-step-output-wcs branch April 8, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants