-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3078: Add support custom reference WCS for the resample step #7442
JP-3078: Add support custom reference WCS for the resample step #7442
Conversation
76eea0b
to
b757e77
Compare
Codecov ReportBase: 78.01% // Head: 78.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #7442 +/- ##
==========================================
+ Coverage 78.01% 78.58% +0.56%
==========================================
Files 453 455 +2
Lines 36830 39200 +2370
==========================================
+ Hits 28732 30804 +2072
- Misses 8098 8396 +298
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
52ab3b2
to
404c589
Compare
0874116
to
24a8ce0
Compare
24a8ce0
to
5809b04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. Updated docs seem to build correctly.
Resolves JP-3078
This PR adds
output_wcs
argument to theresample_step
andresample_spec_step
that allows users to provide their own reference GWCS to the resample step.Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR
Regression test(s):
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/554/