JP-3087: Fix zeroing of NaNs in straylight #7455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbushouse
reviewed
Feb 8, 2023
Codecov ReportBase: 77.90% // Head: 77.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #7455 +/- ##
=======================================
Coverage 77.90% 77.90%
=======================================
Files 455 455
Lines 36975 36977 +2
=======================================
+ Hits 28806 28808 +2
Misses 8169 8169
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Regression test run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/573/ |
|
regtest run showed 1 unrelated failure, due to recent changes in stcal/ramp_fitting. So it's good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a new issue where the MRS straylight routine converts NaNs to zeros. Previously this was a safety catch in case any NaNs were present that were not meant to be there, but now that the rate file is meant to contain NaNs this behaviour is undesirable. This PR modifies straylight to only do the NaN-to-zero conversion in a local copy of the input used for the straylight computation itself.
Resolves JP-3087
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR