Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin stdatamodels to new release #7465

Merged

Conversation

zacharyburnett
Copy link
Collaborator

This PR pins stdatamodels to 1.0.0

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 77.93% // Head: 77.94% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (944d689) compared to base (3f7dcc1).
Patch has no changes to coverable lines.

❗ Current head 944d689 differs from pull request most recent head bb2e2a7. Consider uploading reports for the commit bb2e2a7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7465      +/-   ##
==========================================
+ Coverage   77.93%   77.94%   +0.01%     
==========================================
  Files         455      455              
  Lines       36957    36977      +20     
==========================================
+ Hits        28801    28823      +22     
+ Misses       8156     8154       -2     
Flag Coverage Δ *Carryforward flag
nightly 77.94% <ø> (+<0.01%) ⬆️ Carriedforward from 171b3b7
unit 50.43% <ø> (+0.94%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/assign_wcs/miri.py 90.47% <0.00%> (ø)
jwst/assign_wcs/util.py 83.86% <0.00%> (ø)
jwst/assign_wcs/nircam.py 91.30% <0.00%> (ø)
jwst/assign_wcs/niriss.py 76.70% <0.00%> (ø)
jwst/wavecorr/wavecorr.py 90.35% <0.00%> (ø)
jwst/assign_wcs/nirspec.py 94.02% <0.00%> (ø)
jwst/cube_build/ifu_cube.py 91.57% <0.00%> (ø)
jwst/msaflagopen/msaflag_open.py 100.00% <0.00%> (ø)
jwst/cube_build/cube_internal_cal.py 100.00% <0.00%> (ø)
jwst/lib/set_telescope_pointing.py 85.69% <0.00%> (+0.13%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse
Copy link
Collaborator

Given that the stdatamodels 1.0.0 release is available, shall we go ahead and "undraft" this PR and merge it? Or are you waiting for some other step in the chain of events before doing that?

@zacharyburnett zacharyburnett marked this pull request as ready for review February 14, 2023 19:46
@zacharyburnett
Copy link
Collaborator Author

Given that the stdatamodels 1.0.0 release is available, shall we go ahead and "undraft" this PR and merge it? Or are you waiting for some other step in the chain of events before doing that?

I was waiting for stdatamodels 1.1.0 with new PRs, but that can have a new pin. I'll go ahead and merge this one

@zacharyburnett zacharyburnett merged commit 1ae58f0 into spacetelescope:master Feb 14, 2023
@zacharyburnett zacharyburnett deleted the pin_stdatamodels branch February 14, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants