Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3127: Fix bounding box in MRS TSO observations #7492

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

nden
Copy link
Collaborator

@nden nden commented Mar 13, 2023

Resolves JP-3127

This PR fixes a problem with the computation of the bounding box of a MIRI MRS TSO observation. The bounding box is defined by the shape of the data. The code assumed an MRS observation, the input to assign_wcs is always a 2D image and used the shape of the data array in a simplistic way to determine the bounding box. Since TSO observations are cubes this created very small bounding boxes. Fixed by calling the correct function, transform_bbox_from_shape, already available in assign_wcs/utils.py

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (08b318e) 77.60% compared to head (7cf502a) 77.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7492      +/-   ##
==========================================
- Coverage   77.60%   77.59%   -0.01%     
==========================================
  Files         452      452              
  Lines       36095    36094       -1     
==========================================
- Hits        28010    28008       -2     
- Misses       8085     8086       +1     
Flag Coverage Δ
nightly 77.60% <100.00%> (-0.01%) ⬇️
unit 49.56% <100.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
jwst/assign_wcs/miri.py 90.43% <100.00%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse hbushouse added this to the Build 9.2 milestone Mar 14, 2023
@nden nden requested review from hbushouse and tapastro March 15, 2023 11:34
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe a brief (1 or 2 sentence) description of what the problem was and how it's been fixed would be nice in the description section of the ticket.

@hbushouse
Copy link
Collaborator

hbushouse commented Mar 15, 2023

Regtest run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/601

Whoops, forgot to pin the CRDS context for run 601, so it tried to run snowball flagging without opencv being installed. I've started another run with context pinned to 1062, so that snowball doesn't run:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/602

@hbushouse
Copy link
Collaborator

Regtest run https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/606/ using context 1068 shows 6 expected differences in MRS TSO results. Looks good.

@hbushouse hbushouse merged commit 8d0849b into spacetelescope:master Mar 16, 2023
@nden nden deleted the mrs-bb branch July 26, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants