Fix logic in MIRI LRS spec3 regtest #7497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New truth files have been uploaded to artifactory. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #7497 +/- ##
=======================================
Coverage 77.59% 77.59%
=======================================
Files 452 452
Lines 36094 36094
=======================================
Hits 28008 28008
Misses 8086 8086
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the currently flawed logic in the test_miri_lrs_slit_spec3 regression test module. The problem is that the spec3 pipeline is run multiple times on the same input data, using different specifications for how to create the output/combined image WCS, but all of those different runs get saved using the same s2d product file name. That's fine for most of the tests, because most result in a combined image of the same size, but the very last iteration creates a bigger image. When the "okify_regtests" script is used to update truth files, that last s2d file, which is different size, gets used to update the truth files for all tests, leading to subsequent failures. This PR updates the test module to save the result of the last iteration in a different output file, so that it doesn't clobber the truths for the other iterations.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR