Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use OpenAstronomy workflows and move MacOS jobs to schedule #7498

Merged
merged 5 commits into from
Mar 22, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Mar 14, 2023

This PR abstracts CI workflows to the OpenAstronomy workflows; this should reduce maintenance for updating and maintaining actions. Additionally, these changes move the majority of MacOS jobs to the weekly scheduled workflow. This should alleviate the issue where the limited MacOS runners for the organization are not available for CI jobs.

image

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Mar 14, 2023
@github-actions github-actions bot added automation Continuous Integration (CI) and testing automation tools testing labels Mar 14, 2023
@zacharyburnett zacharyburnett force-pushed the ci_refactor branch 2 times, most recently from f0a57a7 to 09aa828 Compare March 14, 2023 15:45
@zacharyburnett zacharyburnett changed the title use OpenAstronomy workflows use OpenAstronomy workflows and move MacOS jobs to schedule Mar 14, 2023
@nden
Copy link
Collaborator

nden commented Mar 15, 2023

Tests are not running.

@zacharyburnett
Copy link
Collaborator Author

Tests are not running.

It looks like the OpenAstronomy workflow creates a set_env.py file that is not properly cleaned up, so pytest finds it and encounters an error when executing it. I made a PR to attempt to resolve the issue: OpenAstronomy/github-actions-workflows#116

@zacharyburnett
Copy link
Collaborator Author

tests are running now. Required status names in the branch protection rules will have to be updated upon merge.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (78941d9) 77.61% compared to head (a4ef95b) 77.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7498   +/-   ##
=======================================
  Coverage   77.61%   77.61%           
=======================================
  Files         452      452           
  Lines       36193    36193           
=======================================
  Hits        28091    28091           
  Misses       8102     8102           
Flag Coverage Δ *Carryforward flag
nightly 77.60% <ø> (ø) Carriedforward from 78941d9
unit ?

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Mar 15, 2023

The CRDS cache is incorrect because test-opencv-xdist completes before the full tests; this should be resolved by #7499 which removes the separate testing

EDIT: resolved

@zacharyburnett zacharyburnett merged commit 1883fe5 into spacetelescope:master Mar 22, 2023
@zacharyburnett zacharyburnett deleted the ci_refactor branch March 22, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools no-changelog-entry-needed testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants