Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(JP-3138) Add regtest for calwebb_detector1 for undersampling correction #7509

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

dmggh
Copy link
Contributor

@dmggh dmggh commented Mar 25, 2023

Resolves JP-3138

Closes #

This PR adds a regression test for niriss image calwebb_detector1 for testing the undersampling_correction output, and testing the rampfitting output (which contains ramps flagged by the undersampling_correction step ). Documentation for the calwebb_detector1 pipeline will be updated in a separate ticket.
Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.21 🎉

Comparison is base (af63faf) 77.49% compared to head (bf40c4f) 77.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7509      +/-   ##
==========================================
+ Coverage   77.49%   77.70%   +0.21%     
==========================================
  Files         452      452              
  Lines       36193    36193              
==========================================
+ Hits        28047    28124      +77     
+ Misses       8146     8069      -77     
Flag Coverage Δ
nightly 77.69% <ø> (+0.21%) ⬆️

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse
Copy link
Collaborator

Regtest run is at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/614/

The majority of failures are expected, due to MacOS tests always showing slight differences (22 tests). The additional 6 are the expected differences from the undersampling_correction.

1 similar comment
@hbushouse
Copy link
Collaborator

Regtest run is at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/614/

The majority of failures are expected, due to MacOS tests always showing slight differences (22 tests). The additional 6 are the expected differences from the undersampling_correction.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants