Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(JP 3158 ) Update docs for calwebb_detector1 #7510

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

dmggh
Copy link
Contributor

@dmggh dmggh commented Mar 26, 2023

Resolves JP-3158

Closes #

This PR address updates the calwebb_detector1 documentation to include the undersampling correction step.
Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@dmggh dmggh requested a review from hbushouse March 26, 2023 10:21
@dmggh dmggh self-assigned this Mar 26, 2023
@dmggh dmggh added this to the Build 9.2 milestone Mar 26, 2023
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (af63faf) 77.49% compared to head (516e1ce) 77.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7510   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files         452      452           
  Lines       36193    36193           
=======================================
  Hits        28047    28047           
  Misses       8146     8146           
Flag Coverage Δ *Carryforward flag
nightly 77.47% <ø> (ø) Carriedforward from af63faf

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code updates look good and docs built from the PR are also good.

@hbushouse hbushouse merged commit 101db5a into spacetelescope:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants