Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(JP-3126) Clarify text in Jump docs #7518

Merged
merged 5 commits into from
Mar 31, 2023
Merged

Conversation

dmggh
Copy link
Contributor

@dmggh dmggh commented Mar 31, 2023

Resolves JP-3126

Closes #

This PR clarifies the text in the ReadTheDocs for the arguments in the jump step, and corrects typos.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@dmggh dmggh added this to the Build 9.2 milestone Mar 31, 2023
@dmggh dmggh requested review from nden and hbushouse March 31, 2023 07:46
@dmggh dmggh requested a review from a team as a code owner March 31, 2023 07:46
@dmggh dmggh self-assigned this Mar 31, 2023
@github-actions github-actions bot removed the jump label Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.60 ⚠️

Comparison is base (a6b8a78) 77.57% compared to head (d39306e) 76.97%.

❗ Current head d39306e differs from pull request most recent head c273d27. Consider uploading reports for the commit c273d27 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7518      +/-   ##
==========================================
- Coverage   77.57%   76.97%   -0.60%     
==========================================
  Files         452      452              
  Lines       36207    36540     +333     
==========================================
+ Hits        28086    28127      +41     
- Misses       8121     8413     +292     
Flag Coverage Δ *Carryforward flag
nightly 77.56% <ø> (-0.02%) ⬇️ Carriedforward from ae47f34

*This pull request uses carry forward flags. Click here to find out more.

see 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse hbushouse added the jump label Mar 31, 2023
@hbushouse
Copy link
Collaborator

Please fix the text in the description field above so that the tic boxes are handled correctly (no whitespace inside of [])

docs/jwst/jump/arguments.rst Outdated Show resolved Hide resolved
docs/jwst/jump/arguments.rst Outdated Show resolved Hide resolved
docs/jwst/jump/arguments.rst Outdated Show resolved Hide resolved
docs/jwst/jump/arguments.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the jump label Mar 31, 2023
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good and build correctly in docs.

@hbushouse hbushouse merged commit 141ecbc into spacetelescope:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants