Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit data files from coverage tests #7523

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Apr 3, 2023

Resolves JP-3166

This PR addresses the following warnings in coverage tests:

2023-04-03 10:15:22,990 - stpipe - WARNING - /data1/jenkins/workspace/RT/JWST/miniconda/envs/tmp_env0/lib/python3.9/site-packages/coverage/report.py:113: CoverageWarning: Couldn't parse '/data1/jenkins/workspace/RT/JWST/clone/test_outputs/popen-gw11/test_nirspec_missing_msa_fail0/jwst_nirspec_fflat_0017.rmap': No source for code: '/data1/jenkins/workspace/RT/JWST/clone/test_outputs/popen-gw11/test_nirspec_missing_msa_fail0/jwst_nirspec_fflat_0017.rmap'. (couldnt-parse)
  coverage._warn(msg, slug="couldnt-parse")

2023-04-03 10:15:22,990 - stpipe - WARNING - /data1/jenkins/workspace/RT/JWST/miniconda/envs/tmp_env0/lib/python3.9/site-packages/coverage/report.py:113: CoverageWarning: Couldn't parse '/data1/jenkins/workspace/RT/JWST/clone/test_outputs/popen-gw11/test_nirspec_missing_msa_fail0/jwst_nirspec_flat_0015.rmap': No source for code: '/data1/jenkins/workspace/RT/JWST/clone/test_outputs/popen-gw11/test_nirspec_missing_msa_fail0/jwst_nirspec_flat_0015.rmap'. (couldnt-parse)
  coverage._warn(msg, slug="couldnt-parse")

2023-04-03 10:15:22,990 - stpipe - WARNING - /data1/jenkins/workspace/RT/JWST/miniconda/envs/tmp_env0/lib/python3.9/site-packages/coverage/report.py:113: CoverageWarning: Couldn't parse '/data1/jenkins/workspace/RT/JWST/clone/test_outputs/popen-gw11/test_nirspec_missing_msa_fail0/jwst_nirspec_fore_0024.rmap': No source for code: '/data1/jenkins/workspace/RT/JWST/clone/test_outputs/popen-gw11/test_nirspec_missing_msa_fail0/jwst_nirspec_fore_0024.rmap'. (couldnt-parse)
  coverage._warn(msg, slug="couldnt-parse")

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Apr 3, 2023
@zacharyburnett zacharyburnett changed the title omit .rmap and .pmap files omit data files from coverage tests Apr 3, 2023
@zacharyburnett zacharyburnett marked this pull request as ready for review April 3, 2023 15:03
@zacharyburnett zacharyburnett requested a review from a team as a code owner April 3, 2023 15:03
@zacharyburnett
Copy link
Collaborator Author

@hbushouse are there any other file types that come to mind to be omitted?

@hbushouse
Copy link
Collaborator

@hbushouse are there any other file types that come to mind to be omitted?

None that I can see at this time.

setup.cfg Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (275eb0c) 77.69% compared to head (4ab2af8) 77.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7523   +/-   ##
=======================================
  Coverage   77.69%   77.69%           
=======================================
  Files         452      452           
  Lines       36211    36211           
=======================================
  Hits        28133    28133           
  Misses       8078     8078           
Flag Coverage Δ *Carryforward flag
nightly 77.69% <ø> (ø) Carriedforward from 275eb0c

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse hbushouse merged commit fcfb211 into spacetelescope:master Apr 4, 2023
@zacharyburnett zacharyburnett deleted the cov_omit branch April 4, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants