Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3164: Removing tests that are already handled in STCAL or are unneeded. #7530

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

kmacdonald-stsci
Copy link
Contributor

@kmacdonald-stsci kmacdonald-stsci commented Apr 7, 2023

Resolves JP-3164

Closes #

This PR addresses a partial resolution of JP-3164 for ramp fitting CI tests. There were skipped tests in JWST that are already handled in STCAL, so they are unneeded duplicates.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (d4f3985) 77.52% compared to head (61e3563) 77.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7530      +/-   ##
==========================================
- Coverage   77.52%   77.44%   -0.08%     
==========================================
  Files         452      452              
  Lines       36232    36346     +114     
==========================================
+ Hits        28088    28148      +60     
- Misses       8144     8198      +54     
Flag Coverage Δ *Carryforward flag
nightly 77.53% <ø> (ø) Carriedforward from d4f3985

*This pull request uses carry forward flags. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nden nden removed the request for review from dmggh April 8, 2023 20:44
@hbushouse hbushouse merged commit 67dac94 into spacetelescope:master Apr 10, 2023
@hbushouse hbushouse modified the milestones: Build 9.3, Build 9.2 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants