-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-624: Add unit tests to skymatch #7531
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7531 +/- ##
==========================================
+ Coverage 77.62% 77.86% +0.23%
==========================================
Files 452 452
Lines 36206 36206
==========================================
+ Hits 28105 28191 +86
+ Misses 8101 8015 -86
*This pull request uses carry forward flags. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
9fbd73d
to
27e0f46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hbushouse Please do not merge yet. I plan to add tests for the reduced memory usage. I think this would be useful (in the future). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ffea443
to
efbab93
Compare
The average coverage for the |
efbab93
to
2d3c2bf
Compare
2d3c2bf
to
68944aa
Compare
Resolves JP-624
This PR addresses adds unit tests for the
skymatch
stepChecklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR