Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-624: Add unit tests to skymatch #7531

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

mcara
Copy link
Member

@mcara mcara commented Apr 8, 2023

Resolves JP-624

This PR addresses adds unit tests for the skymatch step

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@mcara mcara added this to the Build 9.3 milestone Apr 8, 2023
@mcara mcara self-assigned this Apr 8, 2023
@mcara mcara requested a review from a team as a code owner April 8, 2023 15:30
@mcara mcara requested review from nden and hbushouse April 8, 2023 15:31
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.23 🎉

Comparison is base (33f102e) 77.62% compared to head (8737b6b) 77.86%.

❗ Current head 8737b6b differs from pull request most recent head 68944aa. Consider uploading reports for the commit 68944aa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7531      +/-   ##
==========================================
+ Coverage   77.62%   77.86%   +0.23%     
==========================================
  Files         452      452              
  Lines       36206    36206              
==========================================
+ Hits        28105    28191      +86     
+ Misses       8101     8015      -86     
Flag Coverage Δ *Carryforward flag
nightly 77.64% <ø> (ø) Carriedforward from d61e0b1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/skymatch/skymatch_step.py 92.22% <100.00%> (+21.11%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcara mcara force-pushed the add-skymatch-tests branch 2 times, most recently from 9fbd73d to 27e0f46 Compare April 10, 2023 02:51
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcara
Copy link
Member Author

mcara commented Apr 10, 2023

@hbushouse Please do not merge yet. I plan to add tests for the reduced memory usage. I think this would be useful (in the future).

Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcara mcara force-pushed the add-skymatch-tests branch 2 times, most recently from ffea443 to efbab93 Compare April 12, 2023 13:25
@mcara mcara enabled auto-merge (squash) April 12, 2023 13:26
@mcara
Copy link
Member Author

mcara commented Apr 12, 2023

The average coverage for the skymatch step is 80% with most files being covered > 90%

@mcara mcara force-pushed the add-skymatch-tests branch from efbab93 to 2d3c2bf Compare April 12, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants