Cleanup skymatch code and fix PEP8 issues #7534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7534 +/- ##
==========================================
+ Coverage 77.42% 77.51% +0.08%
==========================================
Files 452 452
Lines 36241 36200 -41
==========================================
- Hits 28060 28059 -1
+ Misses 8181 8141 -40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
perrygreenfield
approved these changes
Apr 9, 2023
|
Regression tests fail but in the same manner as previous runs => this PR did not affect results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply addresses PEP8 issues and also comments out
_calc_sky_origfunction (I just do not have time at this moment to test whether this code can be safely restored. I will do this later but I want to keep it here for convenience.)I expect no changes to any tests. Most PEP8 issues were line length.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR
Regression test is running here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/636/