Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix srctype docs #7536

Merged
merged 5 commits into from
Apr 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,9 +1,35 @@
1.10.1 (unreleased)
===================

- Remove use of deprecated ``pytest-openfiles`` ``pytest`` plugin. This has been replaced by
documentation
-------------

- Corrected information about the application of the ``srctype`` step to WFSS exposures.
[#7536]

extract_1d
----------

- Update to be skipped for NIRSpec fixed slit modes with rateints input as that
mode is not allowed. [#7516]

flat_field
----------

- Updated to allow processing of NIRSpec fixed-slit 3D (rateints) files. [#7516]

other
-----

- Remove use of deprecated ``pytest-openfiles`` plugin. This has been replaced by
catching ``ResourceWarning``s. [#7526]

resample_spec
-------------

- Update ``resample_spec`` to be skipped for NIRSpec fixed slit MultiSlitModel
rateints input as that mode is not allowed. [#7516]


1.10.0 (2023-04-03)
===================
Expand Down Expand Up @@ -32,7 +58,7 @@ calwebb_detector1
cube_build
----------

- Windows: MSVC: Allocate ``wave_slice_dq`` array using ``mem_alloc_dq()`` [#7491]
- Windows: MSVC: Allocate ``wave_slice_dq`` array using ``mem_alloc_dq()`` [#7491]

- Memory improvements, do not allow MIRI and 'internal_cal', allow user to set suffix. [#7521]

Expand Down Expand Up @@ -66,9 +92,6 @@ extract_1d

- Edit surface brightness unit strings for parsing by ``astropy.units`` [#7511]

- Update to be skipped for NIRSpec fixed slit modes with rateints input as that
mode is not allowed. [#7516]

jump
----

Expand Down Expand Up @@ -150,9 +173,6 @@ resample

- Carry through good bits correctly for the variance array [#7515]

- Update ``resample_spec`` to be skipped for NIRSpec fixed slit MultiSlitModel
rateints input as that mode is not allowed. [#7516]

residual_fringe
---------------

Expand Down
4 changes: 2 additions & 2 deletions docs/jwst/pipeline/calwebb_spec2.rst
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ TSO exposures. The instrument mode abbreviations used in the table are as follow
+----------------------------------------------------------+-----+-----+-----+-----+-----+-----+------+------+--------+-----+
| :ref:`extract_2d <extract_2d_step>`\ :sup:`1` | |c| | |c| | | | | | | |c| | |c| | |c| |
+----------------------------------------------------------+-----+-----+-----+-----+-----+-----+------+------+--------+-----+
| :ref:`srctype <srctype_step>`\ :sup:`1` | |c| | |c| | |c| | |c| | |c| | |c| | |c| | | | |c| |
| :ref:`srctype <srctype_step>`\ :sup:`1` | |c| | |c| | |c| | |c| | |c| | |c| | |c| | |c| | |c| | |c| |
+----------------------------------------------------------+-----+-----+-----+-----+-----+-----+------+------+--------+-----+
| :ref:`master_background <master_background_step>` | | |c| | | | | | | | | |
+----------------------------------------------------------+-----+-----+-----+-----+-----+-----+------+------+--------+-----+
Expand Down Expand Up @@ -87,7 +87,7 @@ TSO exposures. The instrument mode abbreviations used in the table are as follow
:sup:`1`\ The exact order of the :ref:`extract_2d <extract_2d_step>`, :ref:`srctype <srctype_step>`,
and :ref:`flat_field <flatfield_step>` steps depends on the observing mode.
For NIRISS and NIRCam WFSS, as well as NIRCam TSO grism exposures, the order is
flat_field followed by extract_2d (no wavecorr or srctype).
flat_field, extract_2d, and srctype (no wavecorr).
For all other modes the order is extract_2d, srctype, wavecorr, and flat_field.

:sup:`2`\ By default the :ref:`residual_fringe <residual_fringe_step>` is skipped in the ``calwebb_spec2`` pipeline.
Expand Down
6 changes: 3 additions & 3 deletions docs/jwst/srctype/description.rst
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,6 @@ NIRCam and NIRISS WFSS
++++++++++++++++++++++
It is not possible to specify ahead of time the source types for spectra that
may show up in a Wide-Field Slitless Spectroscopy exposure. So for these modes
the ``srctype`` step simply sets the SRCTYPE keyword value to "UNKNOWN" and the
actual source sizes are derived from the catalog information generated
from direct images that are obtained as part of a WFSS observation.
the ``srctype`` step uses the value from the ``is_extended`` column of the
source catalog generated from the direct imaging taken with WFSS observations
and uses that to set "POINT" or "EXTENDED" for each extracted source.