-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3156: Fix SOSS-specific spec_table unit labels #7538
JP-3156: Fix SOSS-specific spec_table unit labels #7538
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7538 +/- ##
==========================================
+ Coverage 77.53% 77.63% +0.10%
==========================================
Files 452 452
Lines 36200 36200
==========================================
+ Hits 28066 28105 +39
+ Misses 8134 8095 -39
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should run a regtest, which we know will result in several expected differences. Are there any docs anywhere that mention units that might need updating? Oh, and change log needs a rebase.
37c1143
to
d102b87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regtest shows only expected differences. Looks good to me.
Resolves JP-3156
Closes #
This PR addresses an inconsistency noted between PHOTMJ photom scalar conversion units and the unit labels in the spec_table output for NIRISS SOSS data. To keep the units consistent across exposure types, the correction applied here is to the labels, to consistently store spectral point-source data in units of MJy rather than Jy.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR