Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3156: Fix SOSS-specific spec_table unit labels #7538

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

tapastro
Copy link
Contributor

@tapastro tapastro commented Apr 10, 2023

Resolves JP-3156

Closes #

This PR addresses an inconsistency noted between PHOTMJ photom scalar conversion units and the unit labels in the spec_table output for NIRISS SOSS data. To keep the units consistent across exposure types, the correction applied here is to the labels, to consistently store spectral point-source data in units of MJy rather than Jy.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@tapastro tapastro added this to the Build 9.3 milestone Apr 10, 2023
@tapastro tapastro requested a review from a team as a code owner April 10, 2023 21:09
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (ad89ee0) 77.53% compared to head (37c1143) 77.63%.

❗ Current head 37c1143 differs from pull request most recent head d102b87. Consider uploading reports for the commit d102b87 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7538      +/-   ##
==========================================
+ Coverage   77.53%   77.63%   +0.10%     
==========================================
  Files         452      452              
  Lines       36200    36200              
==========================================
+ Hits        28066    28105      +39     
+ Misses       8134     8095      -39     
Flag Coverage Δ
nightly 77.64% <100.00%> (+0.10%) ⬆️
Impacted Files Coverage Δ
jwst/photom/photom.py 89.10% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should run a regtest, which we know will result in several expected differences. Are there any docs anywhere that mention units that might need updating? Oh, and change log needs a rebase.

@tapastro
Copy link
Contributor Author

@tapastro tapastro force-pushed the jp-3156-soss-spectral-units branch from 37c1143 to d102b87 Compare April 11, 2023 15:36
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regtest shows only expected differences. Looks good to me.

@hbushouse hbushouse merged commit a67f1c9 into spacetelescope:master Apr 11, 2023
@hbushouse hbushouse modified the milestones: Build 9.3, Build 9.2 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants