Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3027: Update requirement for tweakwcs #7551

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

mcara
Copy link
Member

@mcara mcara commented Apr 14, 2023

Resolves JP-3027

Require version 0.8.2 of tweakwcs which will improve speed of alignment to Gaia when input is a large (>50) group of images. Also see spacetelescope/tweakwcs#176

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Regression tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/660/

@mcara mcara added this to the Build 9.3 milestone Apr 14, 2023
@mcara mcara requested a review from hbushouse April 14, 2023 05:22
@mcara mcara self-assigned this Apr 14, 2023
@mcara mcara requested a review from a team as a code owner April 14, 2023 05:22
@mcara mcara changed the title Update requirement for tweakwcs JP-3027: Update requirement for tweakwcs Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8fb5bd7) 77.86% compared to head (bf0c29d) 77.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7551   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files         452      452           
  Lines       36197    36197           
=======================================
  Hits        28184    28184           
  Misses       8013     8013           
Flag Coverage Δ *Carryforward flag
nightly 77.64% <ø> (ø) Carriedforward from 8fb5bd7

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse hbushouse merged commit a1b9677 into spacetelescope:master Apr 15, 2023
@nden
Copy link
Collaborator

nden commented Apr 18, 2023

@mcara Do you have an estimate of the speed up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants