-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace opencv-python
with pre-built CPU-only opencv-python-headless
#7570
replace opencv-python
with pre-built CPU-only opencv-python-headless
#7570
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #7570 +/- ##
=======================================
Coverage 77.56% 77.56%
=======================================
Files 455 455
Lines 36340 36340
=======================================
Hits 28188 28188
Misses 8152 8152
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3986625
to
e7a94a7
Compare
opencv-python
with pre-built CPU-only opencv-python-headless
upstream tests at spacetelescope/stcal#164 |
Looks like the regtest run was aborted. Will there be another? |
yes I ran one at https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/697/pipeline It looks like there were quite a few failures:
|
Those errors also appeared in CI runs for this PR for stdatamodels (where @nden mentioned they should be resolved by new reference files). spacetelescope/stdatamodels#160 (comment) and are likely related to: spacetelescope/stdatamodels#124 |
e7a94a7
to
d12b5f8
Compare
That's because you're letting stdatamodels float to the latest. Must pin to "stdatamodels==1.4.0". |
Ah right, I remember your announcement |
regtest running at https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/702/pipeline with |
regression test is all green now 🎉 |
I see that. One caveat though: the regtests only run on Linux. How do we know everything's OK with builds on a Mac? |
Good point, I started a dev job at https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-devdeps/detail/JWST-devdeps/656/pipeline/ as well with |
The MacOS tests are running into the ephemeral socket errors: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-devdeps/detail/JWST-devdeps/656/pipeline/194#step-196-log-29 However, it looks like there were no import errors (so far), so we'll see if the test failures are just socket errors and precision differences between platforms |
aside from 24 failures in float differences, tests passed on MacOS: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-devdeps/detail/JWST-devdeps/656/pipeline/194#step-196-log-4418 |
Closes spacetelescope/stenv#103
This PR tests replacing
opencv-python
withopencv-python-headless
, a pre-built CPU-only binary, to resolve the issue raised in spacetelescope/stenv#103Checklist for maintainers
added entry inCHANGES.rst
within the relevant release sectionupdated or added relevant testsupdated relevant documentationHow to run regression tests on a PR
Make sure the JIRA ticket is resolved properly