-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3227: Add analog of HST's tweakback tool #7573
Conversation
1c7de6e
to
6e2d3d1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7573 +/- ##
==========================================
+ Coverage 77.46% 77.48% +0.02%
==========================================
Files 456 456
Lines 36540 36591 +51
==========================================
+ Hits 28307 28354 +47
- Misses 8233 8237 +4
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
160d9ec
to
7e2f025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a couple of minor typos it looks OK to me.
One general question: it looks like this will just be available as a function that can be called from the tweakreg.utils
module, right? It's not a new standalone step in the jwst package.
Typos fixed. |
66ccbd2
to
dbe0f0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nden any comments?
The imports don't look good to me. I'll create a PR to fix them. |
Co-authored-by: Howard Bushouse <[email protected]>
Resolves JP-3227
This PR adds functionality similar to HST's
tweakback
task to be able to transfer an alignment solution from a file to another.Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR