Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3227: Add analog of HST's tweakback tool #7573

Merged
merged 4 commits into from
May 19, 2023

Conversation

mcara
Copy link
Member

@mcara mcara commented Apr 27, 2023

Resolves JP-3227

This PR adds functionality similar to HST's tweakback task to be able to transfer an alignment solution from a file to another.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. - no need to run regression tests (new feature)
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@mcara mcara added this to the Build 9.3 milestone Apr 27, 2023
@mcara mcara requested a review from a team as a code owner April 27, 2023 14:34
@mcara mcara self-assigned this Apr 27, 2023
@mcara mcara force-pushed the implement-tweakback branch 2 times, most recently from 1c7de6e to 6e2d3d1 Compare April 27, 2023 14:38
@mcara mcara requested review from nden and hbushouse April 27, 2023 14:42
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 92.15% and project coverage change: +0.02 🎉

Comparison is base (ca78a02) 77.46% compared to head (9e05107) 77.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7573      +/-   ##
==========================================
+ Coverage   77.46%   77.48%   +0.02%     
==========================================
  Files         456      456              
  Lines       36540    36591      +51     
==========================================
+ Hits        28307    28354      +47     
- Misses       8233     8237       +4     
Flag Coverage Δ *Carryforward flag
nightly 77.54% <ø> (ø) Carriedforward from c7726ec

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/tweakreg/utils.py 93.33% <92.15%> (-2.50%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcara mcara force-pushed the implement-tweakback branch 6 times, most recently from 160d9ec to 7e2f025 Compare April 28, 2023 01:44
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a couple of minor typos it looks OK to me.

One general question: it looks like this will just be available as a function that can be called from the tweakreg.utils module, right? It's not a new standalone step in the jwst package.

jwst/tweakreg/utils.py Outdated Show resolved Hide resolved
jwst/tweakreg/utils.py Outdated Show resolved Hide resolved
@mcara
Copy link
Member Author

mcara commented Apr 28, 2023

Typos fixed.

@mcara mcara force-pushed the implement-tweakback branch from 66ccbd2 to dbe0f0e Compare April 28, 2023 18:42
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nden any comments?

@hbushouse hbushouse merged commit 3c3edba into spacetelescope:master May 19, 2023
@nden
Copy link
Collaborator

nden commented May 19, 2023

The imports don't look good to me. I'll create a PR to fix them.

@nden nden mentioned this pull request May 19, 2023
7 tasks
mairanteodoro pushed a commit to mairanteodoro/jwst that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants