Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a table of failing unit tests to the CI workflow summary page #7576

Merged
merged 1 commit into from
May 1, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Apr 28, 2023

This PR uses the new pytest-results-summary keyword in the OpenAstronomy reusable workflow to display test summaries on the job page. Here is an example from spacetelescope/romancal#691:
image

If tests fail, the test-summary action will create a Markdown table of failures:
image

Checklist for maintainers

  • [N/A] added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • [N/A] updated relevant documentation
  • [N/A] added relevant milestone
  • added relevant label(s)
  • [N/A] ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • [N/A] Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Apr 28, 2023
@github-actions github-actions bot added automation Continuous Integration (CI) and testing automation tools testing labels Apr 28, 2023
@zacharyburnett zacharyburnett marked this pull request as ready for review April 28, 2023 16:44
@zacharyburnett zacharyburnett requested a review from a team as a code owner April 28, 2023 16:44
@zacharyburnett zacharyburnett changed the title enable step summary for tests enable step summary for pytest results Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8f690fd) 77.56% compared to head (7589018) 77.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7576   +/-   ##
=======================================
  Coverage   77.56%   77.56%           
=======================================
  Files         455      455           
  Lines       36340    36340           
=======================================
  Hits        28188    28188           
  Misses       8152     8152           
Flag Coverage Δ *Carryforward flag
nightly 77.62% <ø> (ø) Carriedforward from 8f690fd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett
Copy link
Collaborator Author

Test summaries can be found in the CI summary page, for example: https://github.com/spacetelescope/jwst/actions/runs/4833109641/attempts/1#summary-13106400880

@zacharyburnett zacharyburnett changed the title enable step summary for pytest results enable pytest results table in CI workflow May 1, 2023
@zacharyburnett zacharyburnett changed the title enable pytest results table in CI workflow enable pytest results table in CI workflow summary page May 1, 2023
@zacharyburnett zacharyburnett changed the title enable pytest results table in CI workflow summary page add a table of failing unit tests to the CI workflow summary page May 1, 2023
@zacharyburnett zacharyburnett merged commit fd89de0 into spacetelescope:master May 1, 2023
@zacharyburnett zacharyburnett deleted the step_summary branch May 1, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools no-changelog-entry-needed testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants