-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors in change log #7580
Fix errors in change log #7580
Conversation
I assume the entries under the wrong version are from PRs that lived through several releases; I'll look into improving the change log checker to also check if the entry is under the latest version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
That's correct. Sometimes a PR branch sits around long enough that a release happens before the PR finally gets merged, so the entry is then in the wrong section of the log. I guess it would also help if we (as reviewers) make sure that in those situations the PR branch gets rebased, which might automatically fix the location of the log entries. Or if not, we just need to manually check and fix before approving. |
https://github.com/spacetelescope/jwst/actions/runs/4872232055/attempts/1#summary-13202639430
is this expected with MacOS? |
That's an execution time test, to alert us when a step or algorithm suddenly takes much longer to execute than before, and I often see those failures in the Mac tests, just because whatever Mac server/system is being used is way slower than our Linux test system (we see the same thing with regression tests - they take like 2x longer on Mac than Linux). |
oof, GitHub must really be stretching their Mac licenses thin with processor allocation. I guess we can't complain about free CI time, though. Hopefully Boyle will be more stable in the future as well |
While composing the public release notes for B9.2 I noticed a number of errors in the change log. Some were dramatic (e.g. changes being listed under the wrong release version), while others are just updates for clarity and grammar.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR