Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in change log #7580

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented May 3, 2023

While composing the public release notes for B9.2 I noticed a number of errors in the change log. Some were dramatic (e.g. changes being listed under the wrong release version), while others are just updates for clarity and grammar.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett
Copy link
Collaborator

I assume the entries under the wrong version are from PRs that lived through several releases; I'll look into improving the change log checker to also check if the entry is under the latest version

Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse
Copy link
Collaborator Author

I assume the entries under the wrong version are from PRs that lived through several releases; I'll look into improving the change log checker to also check if the entry is under the latest version

That's correct. Sometimes a PR branch sits around long enough that a release happens before the PR finally gets merged, so the entry is then in the wrong section of the log. I guess it would also help if we (as reviewers) make sure that in those situations the PR branch gets rebased, which might automatically fix the location of the log entries. Or if not, we just need to manually check and fix before approving.

@hbushouse hbushouse merged commit 9db591b into spacetelescope:master May 3, 2023
@hbushouse hbushouse deleted the fix_changelog branch May 3, 2023 13:52
@zacharyburnett
Copy link
Collaborator

https://github.com/spacetelescope/jwst/actions/runs/4872232055/attempts/1#summary-13202639430

E       assert 614.6205830574036 < 600

is this expected with MacOS?

@hbushouse
Copy link
Collaborator Author

That's an execution time test, to alert us when a step or algorithm suddenly takes much longer to execute than before, and I often see those failures in the Mac tests, just because whatever Mac server/system is being used is way slower than our Linux test system (we see the same thing with regression tests - they take like 2x longer on Mac than Linux).

@zacharyburnett
Copy link
Collaborator

zacharyburnett commented May 3, 2023

oof, GitHub must really be stretching their Mac licenses thin with processor allocation. I guess we can't complain about free CI time, though. Hopefully Boyle will be more stable in the future as well

mairanteodoro pushed a commit to mairanteodoro/jwst that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants