Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3234: Mask NaN values for background subtraction of "robust mean" #7587

Merged
merged 2 commits into from
May 12, 2023

Conversation

tapastro
Copy link
Contributor

@tapastro tapastro commented May 11, 2023

Resolves JP-3234

Closes #

This PR addresses a bug in the calculation of the mean background value when NaN values are present.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@tapastro tapastro added this to the Build 9.3 milestone May 11, 2023
@tapastro tapastro self-assigned this May 11, 2023
@tapastro tapastro requested a review from a team as a code owner May 11, 2023 19:02
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f3a6047) 77.46% compared to head (2a836ec) 77.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7587   +/-   ##
=======================================
  Coverage   77.46%   77.47%           
=======================================
  Files         456      456           
  Lines       36536    36538    +2     
=======================================
+ Hits        28304    28306    +2     
  Misses       8232     8232           
Flag Coverage Δ *Carryforward flag
nightly 77.55% <ø> (-0.01%) ⬇️ Carriedforward from f3a6047

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/background/background_sub.py 93.57% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse hbushouse added the wfss label May 11, 2023
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have you started a regtest run?

@tapastro
Copy link
Contributor Author

@tapastro
Copy link
Contributor Author

Regtests show only expected errors - ifu cubepars issues and a reference file update for LRS fixed slit extract1d parameters.

@hbushouse hbushouse merged commit 50d471a into spacetelescope:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants