-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3225: Gaia proper motions enabled #7614
JP-3225: Gaia proper motions enabled #7614
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7614 +/- ##
=======================================
Coverage 76.62% 76.62%
=======================================
Files 456 456
Lines 36831 36833 +2
=======================================
+ Hits 28221 28223 +2
Misses 8610 8610
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Co-authored-by: Howard Bushouse <[email protected]>
Co-authored-by: Howard Bushouse <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
It's for maintainers in general. However, it's also a reminder for those submitting PRs about what is expected. I think it's best if you check off items as you work through the PR and comments. It helps greatly the maintainer if those submitting PRs check these off and run regression tests with their PR. |
Another regtest run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/769 |
Another regtest run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/771 |
Looks like 3 regression tests failed related to small difference (~1E-5) in generated results and the truth files. I can try to investigate this, but it may take me a little longer to get up to speed. Once the difference are confirmed to be benign, I can update the truth files. |
I think the small differences showing up are likely expected due to the inclusion of proper motion. I think we can merge the PR and do a detailed investigation of the new results once it's available in jwst/master. |
Resolves JP-3225
This PR enables catalog positions to corrected for GAIA proper motions. The code follows the logic from romancal using an new epoch variable. The default for this variable is set to 2016.0 or no correction.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR